Incomplete fix of grdsample required more work #3688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As documented on the forum, grdsample still failed to set the proper read area for input grids. This time I hopefully paid more attention to details. The two regions (the subset needed to be read and the desired new output region) are now carefully compared to the input grid to ensure that we inlcude all the nodes needed to do a full interpolation. The users case passes for me, several cases I checked (including 360-regions and smaller ones with shifts of longitdues) passes plus the regular test suite.
PaulWessel
added
bug
joa-quim
approved these changes
Jul 19, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Jul 19, 2020
* Incomplete fix of grdsample required more work As documented on the forum, grdsample still failed to set the proper read area for input grids. This time I hopefully paid more attention to details. The two regions (the subset needed to be read and the desired new output region) are now carefully compared to the input grid to ensure that we inlcude all the nodes needed to do a full interpolation. The users case passes for me, several cases I checked (including 360-regions and smaller ones with shifts of longitdues) passes plus the regular test suite. * Update grdsample.c
joa-quim
pushed a commit
that referenced
this pull request
Jul 19, 2020
* Incomplete fix of grdsample required more work As documented on the forum, grdsample still failed to set the proper read area for input grids. This time I hopefully paid more attention to details. The two regions (the subset needed to be read and the desired new output region) are now carefully compared to the input grid to ensure that we inlcude all the nodes needed to do a full interpolation. The users case passes for me, several cases I checked (including 360-regions and smaller ones with shifts of longitdues) passes plus the regular test suite. * Update grdsample.c Co-authored-by: Paul Wessel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented on the forum, grdsample still failed to set the proper read area for input grids. This time I hopefully paid more attention to details. The two regions (the wesn_i subset needed to be read and the desired new output region wesn_o) are now carefully compared to the input grid to ensure that we include all the nodes needed to do a full interpolation. The user's case passes for me, several other cases I checked (including 360-regions and smaller ones with shifts of longitudes) passes plus the regular test suite.